design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Clean up CSS cruft

Open anselmbradford opened this issue 1 year ago • 3 comments

Describe the bug

Post BEM conversion (see https://github.com/cfpb/design-system/pull/1919), here is some additional CSS that can be removed:

  • ~~a-tagline--xlarge~~
  • content--2-1
  • ~~content__wrapper--match-content - this class is being created because content__wrapper extends wrapper, which defines wrapper--match-content.~~
  • ~~content__bleedbar~~

Some refactoring:

  • o-table-wrapper--scrolling should be updated to o-table--scrolling
  • ~~o-form--input-w-btn to not be a modifier of o-form (see https://github.com/cfpb/design-system/pull/1933~~

anselmbradford avatar Mar 28 '24 18:03 anselmbradford

content__bleedbar removed in https://github.com/cfpb/design-system/pull/1954 a-tagline--xlarge removed in https://github.com/cfpb/design-system/pull/1960

anselmbradford avatar Apr 19 '24 20:04 anselmbradford

@anselmbradford will update this issue

sonnakim avatar Jun 27 '24 18:06 sonnakim

content__wrapper--match-content removed in https://github.com/cfpb/design-system/pull/1997 o-form--input-w-btn removed in https://github.com/cfpb/design-system/pull/1979

anselmbradford avatar Jun 27 '24 20:06 anselmbradford

@anselmbradford would you mind updating the status of this one?

sonnakim avatar Oct 01 '24 22:10 sonnakim

o-table-wrapper--scrolling renamed in https://github.com/cfpb/design-system/pull/2068

anselmbradford avatar Oct 15 '24 20:10 anselmbradford

I'm going to close this. The last item, content--2-1, is only used in BAH/OAH Rate Explorer. We could remove it from the DS and re-create it in BAH, but there's a similar class, content--3-1, which has wider use and it seems better to keep those two together. If Rate Explorer removes content--2-1, we can remove it here.

anselmbradford avatar Oct 15 '24 20:10 anselmbradford