design-system icon indicating copy to clipboard operation
design-system copied to clipboard

cfpb-forms: Change `o-form__input-w-btn` to `o-input-w-btn`

Open anselmbradford opened this issue 1 year ago • 2 comments

o-form__input-w-btn implies this class is a modifier on o-form, however, it does not appear with o-form. This pattern was probably developed to mirror o-form__email-signup, which does appear with o-form. This PR updates the class to o-input-w-btn since it doesn't appear on a <form> element.

Changes

  • Change o-form__input-w-btn to o-input-w-btn

Testing

  1. PR checks should pass. https://deploy-preview-1933--cfpb-design-system.netlify.app/design-system/components/text-inputs#button-inside-text-input-with-button should be unchanged

anselmbradford avatar Mar 19 '24 14:03 anselmbradford

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit ace7ef6aacba5cb9812dfebbdc38f3821bdd1180
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/65f9a2e2693c07000819e552
Deploy Preview https://deploy-preview-1933--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 19 '24 14:03 netlify[bot]

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit a48aa11bd6ebaf65d98ab9f45950006fd298d851
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/65f9a4bdbe297700081e89b2
Deploy Preview https://deploy-preview-1933--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 19 '24 14:03 netlify[bot]

Superseded by https://github.com/cfpb/design-system/pull/1979/

anselmbradford avatar May 14 '24 15:05 anselmbradford