design-manual icon indicating copy to clipboard operation
design-manual copied to clipboard

Add secondary button states

Open anselmbradford opened this issue 9 years ago • 6 comments

http://cfpb.github.io/design-manual/ui-toolkit/buttons.html lists the primary button states (hover, active, disabled), but doesn't list the states of the secondary button, beyond the normal state.

anselmbradford avatar Apr 15 '15 19:04 anselmbradford

This would also be important for 508.

JenniferHoran avatar Apr 15 '15 20:04 JenniferHoran

Hey @anselmbradford, I think we can assume that the buttons would follow the same pattern as the blue:

Normal: Gray Hover/focused: Gray 80% Active: Dark Gray Disabled: Gray 20% (should match the blue disabled state)

Do you think this needs to be documented in the Design Manual? I think it's pretty easy to discern, but if others don't, we should document it.

mebates avatar Jun 23 '15 14:06 mebates

Do you think this needs to be documented in the Design Manual? I think it's pretty easy to discern, but if others don't, we should document it.

I'd err on the side of being comprehensive in the design manual and documenting it, particularly since the colors don't use the same name across all states for the primary button. (Someone could get confused by the ambiguity and use Neutral for the Active state, for instance.)

anselmbradford avatar Jun 23 '15 15:06 anselmbradford

@contolini may help out with this!

mebates avatar Jun 29 '15 17:06 mebates

@anselmbradford Is this something that's already in Capital Framework? Just clarifying whether this task is just to add it to the Design Manual documentation?

Is this the code for this? screen shot 2017-08-24 at 5 12 07 pm

nataliafitzgerald avatar Aug 24 '17 21:08 nataliafitzgerald

@nataliafitzgerald yes that's right, see https://cfpb.github.io/capital-framework/components/cf-buttons/#secondary-button

anselmbradford avatar Aug 25 '17 14:08 anselmbradford