capital-framework icon indicating copy to clipboard operation
capital-framework copied to clipboard

SVG icon is stretched in notifications

Open anselmbradford opened this issue 6 years ago • 6 comments

Visit https://cfpb.github.io/capital-framework/components/cf-notifications/ and look at the error notification and see that the icon is stretched slightly tall.

screen shot 2018-10-25 at 10 02 50 am

anselmbradford avatar Oct 25 '18 14:10 anselmbradford

Looks square again.

screen shot 2018-11-05 at 5 55 17 pm

jimmynotjim avatar Nov 06 '18 01:11 jimmynotjim

It appears to depend on the browser window size. It's correct at smaller sizes, but not desktop. Also 👋 Jimmy:

screen shot 2018-11-06 at 9 15 27 am screen shot 2018-11-06 at 9 15 42 am

anselmbradford avatar Nov 06 '18 14:11 anselmbradford

👋

Double check what you're inspecting in those screenshots, one is the svg and one is the path within the svg. The svg itself is expected to be taller than it is wide, because the canvas matches the canvas of Avenir and the icon is set within that canvas to align it to the text.

Unfortunately I'm now seeing in my screen shot the icon is actually breaking outside the overlay box but your small screen screenshot doesn't look like it's doing that. Very weird.

jimmynotjim avatar Nov 07 '18 00:11 jimmynotjim

Double check what you're inspecting in those screenshots, one is the svg and one is the path within the svg. The svg itself is expected to be taller than it is wide, because the canvas matches the canvas of Avenir and the icon is set within that canvas to align it to the text.

Ah good catch, yup path reports a square, but visually it's stretched:

screen shot 2018-11-08 at 9 23 07 am

anselmbradford avatar Nov 08 '18 14:11 anselmbradford

This seems to be different between browsers, too. In FF, it doesn't look stretched, but the left and right edges of the circle are slightly cut off.

In Chrome, it seems to be a rounding issue. I see the stretching as screenshotted above, but if I increase the font-size rule that controls the size of the icon, the problem goes away.

Scotchester avatar Feb 14 '19 21:02 Scotchester

Tab icons are stretched here too https://www.consumerfinance.gov/owning-a-home/closing-disclosure/

Screen Shot 2020-01-09 at 5 00 26 PM

anselmbradford avatar Jan 09 '20 22:01 anselmbradford