capital-framework icon indicating copy to clipboard operation
capital-framework copied to clipboard

Make label heading styles the default

Open anselmbradford opened this issue 8 years ago • 3 comments

See background in https://github.com/cfpb/capital-framework/pull/632#discussion_r142753782

Current behavior

  • The majority of the time label headings are used, not plain labels. This means a-label a-label__heading classes are generally needed.

Expected behavior

  • a-label has the label heading styles and a separate a-label__inline class is added that negates the heading styles. a-label__heading is removed.

anselmbradford avatar Oct 05 '17 14:10 anselmbradford

@anselmbradford should we add this to the v5 project? It'll require updating markup in a lot of places and probably shouldn't be considered backward compatible.

jimmynotjim avatar Oct 05 '17 15:10 jimmynotjim

Added it.

anselmbradford avatar Oct 05 '17 18:10 anselmbradford

Scott and I were discussing this today as part of something unrelated and we had a realization, making the heading style the default would mean unsetting all those styles for the inline modifier. Currently, we're only adding styles, not removing them, so it makes sense from that point of view. One solution might be to make an a-inline-label atom just for inline labels. I'll leave it to you all to decide.

jimmynotjim avatar Aug 01 '18 14:08 jimmynotjim