Consider deprecating `o-form_group`

Open Scotchester opened this issue 8 years ago • 2 comments

It seems to serve no purpose other than adding 30px of bottom margin to whatever it wraps. It seems like it could be replaced by putting that bottom margin on fieldsets and using the u-mb30 utility class when a fieldset is not available.

See discussion here: https://github.com/cfpb/capital-framework/pull/539#issuecomment-315196995

Jul 14 '17 16:07 Scotchester

It's not always wrapping a lone fieldset, in the Sandbox example, the two individual text inputs also live in a group. Well have to spend some time thinking this through for all forms we're currently using.

screen shot 2017-07-14 at 5 02 17 pm

https://cfpb.github.io/capital-framework-sandbox/components/cf-forms/

Jul 14 '17 22:07 jimmynotjim

Spoke in person, I'm convinced to remove the groups and rely instead on fieldsets.

Jul 17 '17 19:07 jimmynotjim