capital-framework icon indicating copy to clipboard operation
capital-framework copied to clipboard

[cf-grid] Is the .ie negative right margin override really necessary?

Open KimberlyMunoz opened this issue 9 years ago • 1 comments

Original Issue: https://github.com/cfpb/cf-grid/issues/19

@contolini @Scotchester any idea why IE needed -0.26em instead of -0.25em? When I remove the override and let it use -0.25em the grid still works fine as seen here: http://himedlooff.github.io/cf-grid/custom-demo/

If we can ditch it then we'd save on creating an extra heap of rules. We can also leave out the conditional class for ie and just stick with lt-ie8. At least for the purposes of cf-grid requirements.

Tested on:

IE 11 ie11

IE 10 ie10

IE 9 ie9

IE8 ie8

IE 7 gets a whole set of other overrides including margin right 0. So this wouldn't affect it.

KimberlyMunoz avatar Nov 04 '15 21:11 KimberlyMunoz

Reposting my comment from the previous thread:

I am fairly certain I wrote that bit. For whatever reason, when I was testing it back then, I found that -0.25em on IE would round just high enough that columns would break onto new lines. I can't be sure what has changed between now and then, but I don't particularly care :) If your tests are showing all good, I'm fine with your plan.

Scotchester avatar Nov 04 '15 21:11 Scotchester