segmentation.evaluation

segmentation.evaluation copied to clipboard

assert len(window) is window_size + 1 for equal numbers

1

Hello, I would like to report wrong usage of `assert x is y` line: https://github.com/cfournie/segmentation.evaluation/blob/master/segeval/window/windowdiff.py line 110 ``` python assert len(window) is window_size + 1 ``` fails. It should be...

janrygl

if len(window) > 256 the assertion is false.

rotmanmi

We are counting (near) matches, not edits, so we want 1-weight.

3

I believe that transportations were being weighted incorrectly for `n_t > 2`. In the confusion matrix we want close transpositions to be closer to 1.

rybesh

Hypothesis is on the left (a), reference is on the right (b).

1

If the order of arguments is `hyp, ref` then `hyp` is side `a` and `ref` is side `b`.

rybesh

Possible fix for issue #2. Note that this breaks nine tests.

rybesh

window_diff algorithm is not implemented robustly. for example, if `hypothesis = [2]` and `reference = [1,1]` then `window_diff(hypothesis, reference)` would report an error > decimal.InvalidOperation: 0 / 0

haiahaiah