Cory Francis Myers

@legoktm in : > Remaining steps: > * Documentation updates/tweaks 9c9a65e3302ccd6340f3d664431eae38493bd149 proposes a minimal documentation fixup for 817fec96ac530ef6d61a3f977b5b1b0466bf14e9. Let me know if there's more you'd like to have here, @legoktm.

Bilateral review in progress: I've read through everything and have review comments pending. Most of them are just "We should add a docstring here" or "We should rustdoc this", so...

> * [x] Start dev instance with `cd client && ./run.sh` and test syncing, sending replies and downloading attachments works fine Works fine, but led to #1996, with some follow-up...

430bd8427f10adde5e6f958ee42f9cdafacd1418 adds the diagram I found myself needing while tracing the new proxy in a development environment. The rest of the readme stands as it is, since `securedrop-proxy` is now...

@legoktm, I haven't bisected to confirm this hypothesis, but it occurs to me that c6a13d0ee428aa489ab14ca62a04a4233f9d5c33 changes the version of `werkzeug`, which appears in (e.g.): https://github.com/freedomofpress/securedrop-client/blob/a93ca77dbd77ce9a2c039d4847911ca09c3205df/client/tests/functional/data/test_delete_source.yml#L15-L20 Might as well amend `make...

When actually running via qrexec, it looks like we get logging of the headers of streamed responses for free since the proxy writes them via stderr, e.g.: ``` May 9...

44cd324dbf33c509a1f05c8f3bb7d605fb8247ec gives a naïve wrapper script `with-qubesdb` like so: ```sh-session user@sd:~/securedrop-client$ ./with-qubesdb -h usage: with-qubesdb [-h] [-k KEY] Use -k/--key one or more times to read the specified key from...

On Mon, Mar 11, 2024 at 08:23:59AM -0700, Kunal Mehta wrote: > I'm not opposed to envsubst but I don't really see the advantage of > using it - in...

At c1734bf86783e3bed7c4b241a2defa4b54bc6150: ```sh-session user@sd:~/securedrop-client$ cat > i-know-this-isnt-a-real-tor-config.json.jinja2 EOF user@sd:~/securedrop-client$ ./with-qubesdb -k SD_PROXY_ORIGIN i-know-this-isnt-a-real-tor-config.json.jinja2 i-know-this-isnt-a-real-tor-config.json user@sd:~/securedrop-client$ cat i-know-this-isnt-a-real-tor-config.json {"hidsrv": "foobar"} ```

Rebased from `main`; `envsubst` approach removed in favor of Jinja templating; and typing corrected, with one caveat in .