brackets-csslint icon indicating copy to clipboard operation
brackets-csslint copied to clipboard

Not working with LESS files

Open uxjens opened this issue 11 years ago • 18 comments

It seems that this plugin do not work with LESS files, am I correct?

uxjens avatar Sep 24 '13 12:09 uxjens

Correct. But note I'm pushing a new version tailored for S31 that uses the new linting API. I do not believe it will lint LESS files, but it may help a bit.

On Tue, Sep 24, 2013 at 7:39 AM, uxjens [email protected] wrote:

It seems that this plugin do not work with LESS files, am I correct?

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18 .

Raymond Camden, Adobe Developer Evangelist

Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster avatar Sep 24 '13 13:09 cfjedimaster

Btw, see issue 16 for my conversation w/ Peter Flynn about this.

cfjedimaster avatar Sep 24 '13 13:09 cfjedimaster

Ok, thanks for quick reply

uxjens avatar Sep 25 '13 07:09 uxjens

Note the comment on issue 16. Do you feel comfortable making the code tweak and reporting back how well it works with LESS? I don't use LESS so it would be hard for me to judge.

cfjedimaster avatar Sep 25 '13 10:09 cfjedimaster

Sorry, I'm not a coder, I only know css/less. I can check if it works with less if I get an updated plugin.

uxjens avatar Sep 25 '13 10:09 uxjens

Make sure you remove the existing plugin. Get a new copy here:

https://dl.dropboxusercontent.com/u/88185/brackets-csslint.zip

Let me know. Oh, make sure you are using Sprint 31 too.

On Wed, Sep 25, 2013 at 5:50 AM, uxjens [email protected] wrote:

Sorry, I'm not a coder, I only know css/less. I can check if it works with less if I get an updated plugin.

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-25077067 .

Raymond Camden, Adobe Developer Evangelist

Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster avatar Sep 25 '13 10:09 cfjedimaster

I'm on 31. I'll get back to you.

uxjens avatar Sep 25 '13 10:09 uxjens

Hey I just tried to use this new updated version in Brackets 31 on a SCSS file and no go. says "No Linter available for SCSS"

cpoteet avatar Oct 07 '13 20:10 cpoteet

This is lame, but can you share a file with me? As I don't use LESS, it will be quicker if you could. It would also help if you intentionally broke something that you know should make the linter be upset.

cfjedimaster avatar Oct 07 '13 20:10 cfjedimaster

Not lame at all. Here's the file. It's SASS not LESS, but it's the same root problem. And yes I added that "frak" example you had in a blog post.

On Mon, Oct 7, 2013 at 4:20 PM, Raymond Camden [email protected]:

This is lame, but can you share a file with me? As I don't use LESS, it will be quicker if you could. It would also help if you intentionally broke something that you know should make the linter be upset.

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-25841564 .

cpoteet avatar Oct 07 '13 20:10 cpoteet

Sorry - where is it? I don't think you can include attachments via mail for Git.

cfjedimaster avatar Oct 07 '13 20:10 cfjedimaster

Sorry, try this https://dl.dropboxusercontent.com/u/12206/sp-sass.zip

On Mon, Oct 7, 2013 at 4:59 PM, Raymond Camden [email protected]:

Sorry - where is it? I don't think you can include attachments via mail for Git.

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-25844709 .

cpoteet avatar Oct 08 '13 01:10 cpoteet

Hello,

I usually use LESS for my projects and I confirm that CSSlint doesn't work with .less files on Brackets sprint 33

raphaelgoetter avatar Nov 03 '13 10:11 raphaelgoetter

So I checked in support to make it work with the extension, and it runs. I just don't know how useful it is now. Try it out.

Raphael, how about editing my extension to add support for less. (It is one line - I can tell you which one if you want.) Let me know if it works ok?

On Sun, Nov 3, 2013 at 4:33 AM, Raphael Goetter [email protected]:

Hello,

I usually use LESS for my projects and I confirm that CSSlint doesn't work with .less files on Brackets sprint 33

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-27642119 .

Raymond Camden, Adobe Developer Evangelist

Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster avatar Nov 03 '13 15:11 cfjedimaster

"Raphael, how about editing my extension to add support for less. (It is one line - I can tell you which one if you want.) Let me know if it works ok?"

Yes I'd like to know how to try this extension. Is it about the link in this previous comment ? https://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-25077154

raphaelgoetter avatar Nov 03 '13 17:11 raphaelgoetter

Open main.js from the extension. Find this block:

CodeInspection.register("scss", {
    name: "CSSLint",
    scanFile: cssLinter
});

Copy it - paste it - and change scss to less. Then reload Brackets.

On Sun, Nov 3, 2013 at 11:29 AM, Raphael Goetter [email protected]:

"Raphael, how about editing my extension to add support for less. (It is one line - I can tell you which one if you want.) Let me know if it works ok?"

Yes I'd like to know how to try this extension. Is it about the link in this previous comment ? #18 (comment)https://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-25077154

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-27649214 .

Raymond Camden, Adobe Developer Evangelist

Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster avatar Nov 03 '13 18:11 cfjedimaster

Yay, thats works pretty fine !

Only problem is that Lint stops at the first "LESS" error.

Exemple 1 : @color: red; #sncqcb {cocqn: so,od} #loul {color: @color;}

Result : 1 error ("unknown @rule @color")

Exemple :2
#sncqcb {cocqn: so,od} #loul {color: @color;}

Result : 5 errors ("dont'use id", etc.)

:/

raphaelgoetter avatar Nov 03 '13 19:11 raphaelgoetter

Yeah - thats my concern for both LESS and SASS. This is why I kinda don't want to support it. :)

On Sun, Nov 3, 2013 at 1:12 PM, Raphael Goetter [email protected]:

Yay, thats works pretty fine !

Only problem is that Lint stops at the first "LESS" error.

Exemple 1 : @color https://github.com/color: red; #sncqcb {cocqn: so,od} #loul {color: @color https://github.com/color;}

Result : 1 error ("unknown @rule https://github.com/rule @colorhttps://github.com/color ")

Exemple :2

#sncqcb {cocqn: so,od} #loul {color: @color https://github.com/color;}

Result : 5 errors ("dont'use id", etc.)

:/

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-csslint/issues/18#issuecomment-27651508 .

Raymond Camden, Adobe Developer Evangelist

Email : [email protected] Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster avatar Nov 03 '13 19:11 cfjedimaster