Christophe Fergeau
Christophe Fergeau
@MrEcco one thing which is missing from the PR is a signed-off-by, see https://github.com/containers/gvisor-tap-vsock/pull/484/checks?check_run_id=38666327398
After the addition of the DCO, there is no longer a commit log to your change :-/ The initial description in the PR should be good as a commit log....
I’ve rebased this and squashed the commits which go together in https://github.com/cfergeau/gvisor-tap-vsock/tree/MrEcco The modified version works fine with podman-machine and macadam on a mac. I need to take a closer...
So I’ve looked some more at this branch, rebased it and did a few more cleanups, mostly in the test code. Imo the config file commit is good to go,...
/lgtm /approve
This seems to be fixed after updating gvisor to a newer version as I did in https://github.com/cfergeau/gvisor-tap-vsock/tree/update-gvisor Could be thanks to this change https://github.com/google/gvisor/commit/496c2181b90ecde4714af2aee59a83d4e65a719a
> This seems to be fixed after updating gvisor to a newer version as I did in https://github.com/cfergeau/gvisor-tap-vsock/tree/update-gvisor I was too hasty in my conclusion, this branch breaks all pings,...
I force pushed to rebase the PR. Imo we could give it a go (ie merge it)
> @cfergeau I'll do a rebase and update to my branch quick. I’ve done the rebase. I’ve seen there’s a 0.0.5 release, but the update to go 1.25 is not...
What are you trying to achieve? If your goal is to run `go vet` on the crc codebase, this is already done through golangci-lint, `govet` is enabled by defaut. This...