Chris Ferdinandi comments

Results 95 comments of


                                            Chris Ferdinandi

Restore customError property in the ValidityState() polyfill

Sorry for being dense, but can you tell me what this PR does? Been a little while since I looked at the code on this. Thanks!

Restore customError property in the ValidityState() polyfill

Makes sense, thanks! And I do that ALL the time. No worries! I'll get this merged soon.

Config of error message : Failure when defined via function + constraint is outOfRange or wrongLength

sorry y'all, this has just not been a priority for me at the moment. 😔

Config of error message : Failure when defined via function + constraint is outOfRange or wrongLength

I mean, I'm always open to PRs on this free software 😉

Allow field-specific custom messages.

This is an interesting one. Let me sit on it for a little bit.

only use event.preventDefault() in submitHandler if form invalid

Can you say a bit more? Open to this PR, just want to understand it.

only use event.preventDefault() in submitHandler if form invalid

Thank you. Yes, that makes perfect sense, and I appreciate the clarification. I'll test this locally, run an updated build, and merge later when I get a spare moment. Thanks...

Only run custom validations on fields that need them.

I'm a bit confused by this one. Custom validations are only run on fields with a provided `pattern` (which is totally optional). Everything else falls back to default validations for...

Async custom validations

Hi there... I'm not sure I understand what this means. Can you say more?

Async custom validations

Sorry, I meant: what is it you're trying to accomplish? It looks like perhaps using a server to validate values instead of the client?