Ceyhun Onur

Results 78 issues of Ceyhun Onur

We have deprecated legacy gossip handler in favor of p2p sdk gossip handler (push/pull gossips). We have removed it from coreth with the PR https://github.com/ava-labs/coreth/pull/706 Coreth PR is a big...

cleanup

## Why this should be merged ## How this works ## How this was tested ## Need to be documented? ## Need to update RELEASES.md?

## Why this should be merged ## How this works ## How this was tested ## Need to be documented? ## Need to update RELEASES.md?

Gas price oracle (more specifically fee info provider) works async and subscribes to accepted feed. Which happens regardless of this eth can be called or not. So if a node...

Can we unify all of these implementations? - https://github.com/ava-labs/coreth/blob/0a6ce77563f1865b0a05f8d507bb6a4ba222aa26/plugin/evm/customtypes/header_ext_test.go#L192 - https://github.com/ava-labs/coreth/blob/0a6ce77563f1865b0a05f8d507bb6a4ba222aa26/utils/numbers.go#L11 I think a single: ```golang func PointerTo[T any](x T) *T { return &x } ``` should work for all...

There are some TODOs that start with // TODO Cleanup that can be removed after Granite checks

We're re-doing (almost) all verification in bootstrapping. We can move some of verifications out of that scope, so they don't run in bootstrapping mode.

cleanup

There are some checks that predated after activation of previous upgrades. We should be able to clean up: * Checks in block verification that're guaranteed to be passed for ancient...

cleanup

Currently, there is no visibility into how a PR affects our test coverage. Reviewers must run tests locally or dig into raw CI reports, which slows down code review and...

testing

There are some tests that requires certain json files to be updated under `testdata/`. Those can be updated via golang tests by enabling`WRITE_TEST_FILES` flag. This would write the correct values...