francesco
francesco
> So, to be compliant with json schema, you have to check that it is explicitly not false. should I add this check? ```js if (!hasRequiredProperties && (propertiesKeys.length > 1...
done https://github.com/fastify/fast-json-stringify/pull/802/commits/a1fade334c05a666ef77ded5816535bc9196fe14
done https://github.com/fastify/fast-json-stringify/pull/802/commits/c8a0a47c14dc7cab6aec6543ed6cb7eb0124bdcf Side note: the current tests also cover this changes
> Why did the CI not fail on first commit? also my new test https://github.com/fastify/fast-json-stringify/commit/c8a0a47c14dc7cab6aec6543ed6cb7eb0124bdcf don't fail with first commit 😂 I didn't understand what I have to test in...
> I think there is more then one places use this syntax like hapi & koa template service. Can you make it right in once? done
> [#1692 (comment)](https://github.com/lukeautry/tsoa/pull/1692#discussion_r1786227992) Can I have reason? This version: ```js if (headers) { Object.keys(headers).forEach((name: string) => { response.set(name, headers[name]); }); } ``` is more performant than: ```js Object.keys(headers || {}).forEach((name:...