sails-hook-sequelize-blueprints icon indicating copy to clipboard operation
sails-hook-sequelize-blueprints copied to clipboard

Dead or unnecessary code

Open thomasfr opened this issue 9 years ago • 1 comments

Is it possible that there is some dead code which gets not executed due to copy&paste from core blueprints hook? For instance: https://github.com/cesardeazevedo/sails-hook-sequelize-blueprints/blob/master/actions/add.js#L111 - Because pubsub has to be disabled anyways. Or this file: https://github.com/cesardeazevedo/sails-hook-sequelize-blueprints/blob/master/jsonp.js Is that correct? If you want i can remove that lines and files.

thomasfr avatar Oct 15 '15 20:10 thomasfr

Yes, it's a fork from the original sails blueprints, which there's a lot of dead code as well (https://github.com/balderdashy/sails/blob/master/lib/hooks/blueprints/jsonp.js)

fell free to remove it.

About pubsub, i haven't tested it yet, can leave it there for now.

Thank you.

cesardeazevedo avatar Oct 16 '15 06:10 cesardeazevedo