intelmq Shadowserver database upgrade statements are erroneous

For example the first entry:

UPDATE events
   SET "classification.identifier" = 'open-adb'
   WHERE "classification.identifier" = 'accessible-adb';

The identifier for this feed was previously accessible-adb and is still accessible-adb. Why should the values in the database be changed to open-adb now?

Same with other entries.

@elsif2

Sep 20 '22 16:09 sebix

The database updates were included in the original merge request and should have been reversed when I reworked the schema to maintain the original names. I can remove these in the shadowserver-20220909 branch I have open for a few other updates.

Sep 20 '22 16:09 elsif2

ok. That would have prevented some work regarding backwards-compatibility on my side.

Yes, please remove these wrong statements and replace them with a note, that if users already executed them, they need to revert.

Sep 20 '22 16:09 sebix

Included in https://github.com/certtools/intelmq/commit/8880e0955c2c93b5b3ab9bef03f87e895cdbf267

Sep 20 '22 17:09 elsif2

Fix included in https://github.com/certtools/intelmq/pull/2246

Oct 04 '22 23:10 elsif2

I think this is fixed

Dec 23 '22 08:12 sebix