Update _config.py

[oencarnacion]

location corrections and confirmation of some reports that shadowserver still sends to its recipients

[oencarnacion]

Update

[sebix]

ping @elsif2 for review

[codecov-commenter]

Codecov Report

Merging #2199 (8d21892) into develop (79cae29) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2199      +/-   ##
===========================================
+ Coverage    76.34%   76.36%   +0.01%     
===========================================
  Files          441      441              
  Lines        23654    23671      +17     
  Branches      3739     3739              
===========================================
+ Hits         18059    18076      +17     
  Misses        4858     4858              
  Partials       737      737              

Impacted Files	Coverage Δ
intelmq/bots/parsers/shadowserver/_config.py	98.87% <100.00%> (+0.12%)	:arrow_up:

[elsif2]

ping @elsif2 for review

Once #2143 is accepted, any user submitted changes between the CONFGEN markers will be overwritten since the intelmq/bots/parsers/shadowserver/_config.py is machine generated from our report schema.

The following are all duplicates except scan_epmd which was added to the pull request today.

#2199	#2143
open6_telnet	scan6_telnet
open_amqp	scan_ampq
open_scan_ddos_middlebox	scan_ddos_middlebox
open_scan_dvr_dhcpdiscover	scan_dvr_dhcpdiscover
scan_epmd	scan_epmd
ssl_poodle46_vulnerable_servers (165 & 597)	scan_ssl_poodle
scan_ics	scan_ics
scan_kubernetes	scan_kubernetes
scan_quic	scan_quic
scan_socks	scan_socks
scan_ssh	scan_ssh
accessible_ssl	scan_ssl
device_id	device_id
open_mysql	scan_mysql
open6_ssl	scan6_ssl
open6_ssh	scan6_ssh
open_smtp	scan_smtp
open6_smtp	scan6_smtp

[oencarnacion]

Nice! Will the request be accepted by you?

Enviado desde mi Samsung Mobile de Claro Obtener Outlook para Androidhttps://aka.ms/AAb9ysg

---

From: elsif2 @.> Sent: Friday, July 1, 2022 4:19:22 PM To: certtools/intelmq @.> Cc: Oscar Encarnación @.>; Author @.> Subject: Re: [certtools/intelmq] Update _config.py (PR #2199)

ping @elsif2https://github.com/elsif2 for review

Once #2143https://github.com/certtools/intelmq/pull/2143 is accepted, any user submitted changes between the CONFGEN markers will be overwritten since the intelmq/bots/parsers/shadowserver/_config.py is machine generated from our report schema.

The following are all duplicates except scan_epmd which was added to the pull request today.

#2199https://github.com/certtools/intelmq/pull/2199 #2143https://github.com/certtools/intelmq/pull/2143 open6_telnet scan6_telnet open_amqp scan_ampq open_scan_ddos_middlebox scan_ddos_middlebox open_scan_dvr_dhcpdiscover scan_dvr_dhcpdiscover scan_epmd scan_epmd ssl_poodle46_vulnerable_servers (165 & 597) scan_ssl_poodle scan_ics scan_ics scan_kubernetes scan_kubernetes scan_quic scan_quic scan_socks scan_socks scan_ssh scan_ssh accessible_ssl scan_ssl device_id device_id open_mysql scan_mysql open6_ssl scan6_ssl open6_ssh scan6_ssh open_smtp scan_smtp open6_smtp scan6_smtp

— Reply to this email directly, view it on GitHubhttps://github.com/certtools/intelmq/pull/2199#issuecomment-1172456937, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU3G4XYG4JSBRSE4454622TVR4D7VANCNFSM52MFK7IQ. You are receiving this because you authored the thread.Message ID: @.***>

[sebix]

Dear @elsif2,

As you are the maintainer of the shadowserver-components in IntelMQ, I kindly ask you to review and decide on the Pull Requests, including this one?

Thanks

[elsif2]

All supported report types have been updated in the current develop branch and will be included in release 3.1.0.

[sebix]

@elsif2 Thank you for conclusion.

@oencarnacion Nevertheless this PR has been obsoleted by the recent activities, I esteem your willingness to contribute and respect the time you've invested in it.