Fix #2164: Implement skip_header enhancement
Thank you for implementing this feature request! I was hoping to get to it myself eventually, but you were faster. :-)
Codecov Report
Merging #2171 (fd9d583) into develop (0221a25) will decrease coverage by
0.00%. The diff coverage is88.88%.
@@ Coverage Diff @@
## develop #2171 +/- ##
===========================================
- Coverage 76.34% 76.33% -0.01%
===========================================
Files 441 442 +1
Lines 23649 23672 +23
Branches 3739 3738 -1
===========================================
+ Hits 18055 18071 +16
- Misses 4857 4861 +4
- Partials 737 740 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| intelmq/bots/parsers/generic/parser_csv.py | 84.82% <62.50%> (-2.22%) |
:arrow_down: |
| ...neric/test_parser_csv_data_type_multiple_header.py | 100.00% <100.00%> (ø) |
|
| intelmq/tests/lib/test_exceptions.py | 95.65% <0.00%> (-4.35%) |
:arrow_down: |
| intelmq/bots/experts/modify/expert.py | 94.66% <0.00%> (-2.67%) |
:arrow_down: |
The docs need to be update too.
This enhancement has been merged as PR #2313.
Close?
Thanks for the reminder AFAIK @gutsohnCERT is not active anymore (please object if I'm wrong) and the feature is already implemented by @gethvi