intelmq icon indicating copy to clipboard operation
intelmq copied to clipboard

Bots' offline database update routine: skip, if no bot is enabled

Open ghost opened this issue 4 years ago • 0 comments

Several expert bots have the capability, to update their needed local copy of an external database. They update-routine currently checks, if any such bot is configured before starting actually: https://github.com/certtools/intelmq/blob/9eb388e8f56b5844c86f9da9d1fe8acd8fecfa63/intelmq/bots/experts/tor_nodes/expert.py#L79-L90 This can be extended by checking if any such bot is actually enabled. If no expert is enabled, the routine can be skipped as well. As opposed to collectors, running experts "scheduled" with enabled == False is not meaningful, so I think we can assumed that a disabled expert is really disabled. (Also saves bandwith, especially on testing systems, which have disabled bots ;) )

ghost avatar Sep 06 '21 05:09 ghost