intelmq icon indicating copy to clipboard operation
intelmq copied to clipboard

New Parser for JSON data

Open kbrajneesh opened this issue 5 years ago • 2 comments

This parser can translate json key into harmonized key field and can create events from list of dict within key of JSON.

kbrajneesh avatar Dec 14 '20 12:12 kbrajneesh

Hi, thanks a lot for your contribution! That looks like a very useful parser. Could you make your commit messages a bit more verbose? It would be great if the information you added in the pull request would be part of the commit message, i.e.

Add a new JSONCustom parser Bot

JSON Custom Parser allows can translate json key into harmonized key field 
and can create events from list of dict within key of JSON

and for the documentation commit (if you want to keep that separate - you could also simply squash to one commit!)

DOC: add documentation for the JSON Custom Parser

The JSON Custom Parser converts from a custom JSON-String into an Event.
This adds an explanation and examples to the Bot documentation.

Also there are a lot of unnecessary changes in the bots.rst file, it seems your editor somehow tries to change spaces in the whole file? See https://github.com/certtools/intelmq/pull/1684/commits/35ff026a6c7f989b1a25aa7904146bb95e14208f - it would be great if that could be fixed.

ghost avatar Dec 16 '20 07:12 ghost

Hi, all requested changes have been made in previous commit.

kbrajneesh avatar Dec 19 '20 11:12 kbrajneesh