Update libs

[ghost]

bcdfd2d252b36c4a21a3789aff47ca3d500e4d5d updated jquery 1.11.0 to 3.2.1 and metisMenu from 1.0.3 to 2.7.0 but this breaks the sidebar (un)collapsing in Firefox and has been reverted in 498deff32f62f62a00c6db5c25188380f6fa4b91

[bernhardreiter]

We shall make a new attempt to update jquery as part of solving #111 . @MaximilianKrambach took a look a while ago, and started to look at the sidebar collapsing problem, which maybe sitting in https://github.com/certtools/intelmq-manager/blob/develop/intelmq-manager/js/sb-admin-2.js#L48

The original problem may probably be fixed by "splitting" the line in sb-admin2.js:48 to:

$(window).bind("load", resize_handler);
$(window).bind("resize", resize_handler);

(not tested yet)

Also we'd need to check for compatibility with other jquery using libraries, if we update to the latest version of jquery (https://github.com/jquery/jquery/releases/tag/3.5.1 today). This issue may also security related as elder jquery versions maybe unmaintained and having security issues.

[bernhardreiter]

@wagner-certat to you by chance remember what the problem was described as

breaks the sidebar (un)collapsing in Firefox

?

Just wondering, because I've did an update to the latest jquery 3.5.1 and clicked around and did not find a problem so far. (Simple patch https://github.com/Intevation/intelmq-manager/commit/d3a9868304df57a2f41b46cb09a17b0692477759)

Tested with

Chromium 80.0.3987.162 built on Debian 10.3, running on Debian 10.4
Mozilla Firefox 68.9.0esr

considerations

Selecting the new minimised version from https://jquery.com/download/

curl -O https://code.jquery.com/jquery-3.5.1.min.js

Does it make sense to keep a copy of the source map or uncompressed source around in the repo? Maybe it does to increase longterm avalability of the sources.

[bernhardreiter]

checking other libraries besides jquery

https://github.com/almende/vis has moved on to https://github.com/visjs and got more modularised, so it would have to ported.

https://github.com/onokumus/metisMenu has a version 3 now and also offers a version without jquery. The used version here is really old, but there is no good changelog that could be used to see if it needs updating.

Boostrap: we use 3.2.0 and the latest of that line is 3.4.1 as there are issues fixed, we should consider an upgrade https://snyk.io/vuln/npm:bootstrap:20160627 (though we don't know if we are affected).

datatables: we have 1.10.16 current is 1.10.21 , no good changelog, but it should still be compatible with bootstrap3. So an update could be tried.

[bernhardreiter]

And update of bootstrap also worked fine, just needed one detail fix in the navbar.

Noticed that there is no responsive collapsing of the menu bar neither before nor after my changes. Maybe that has never existed.

[aaronkaplan]

I believe neither me nor @wagner_certat are good at dringend / JS stuff. Best to ask Edvard or just go with your proposals in case you have a better idea for the JS part.

---

Mobile

On 11.06.2020, at 13:37, Bernhard E. Reiter [email protected] wrote:

 checking other libraries besides jquery

https://github.com/almende/vis has moved on to https://github.com/visjs and got more modularised, so it would have to ported.

https://github.com/onokumus/metisMenu has a version 3 now and also offers a version without jquery. The used version here is really old, but there is no good changelog that could be used to see if it needs updating.

Boostrap: we use 3.2.0 and the latest of that line is 3.4.1 as there are issues fixed, we should consider an upgrade https://snyk.io/vuln/npm:bootstrap:20160627 (though we don't know if we are affected).

datatabels: we have 1.10.16 current is 1.10.21 , no good changelog, but it should still be compatible with bootstrap3. So an update could be tried.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ghost]

@wagner-certat to you by chance remember what the problem was described as

breaks the sidebar (un)collapsing in Firefox

?

Just wondering, because I've did an update to the latest jquery 3.5.1 and clicked around and did not find a problem so far. (Simple patch Intevation@d3a9868)

The description is not good, I agree. As I didn't remember exactly, I tested it with 39077d9 (the commit before the revert) and I cannot open the "Collectors" etc. views in the sidepanel in the configuration tab. With Firefox 77 and Chromium version 83 now.

[bernhardreiter]

@wagner-certat thanks for the description, with the update in my branch the sidebar seems to work fine. So that maybe was more a metisMenu problem, than a jquery problem.

@aaronkaplan thanks for caring. Just to explain: usually I just put in my notes here, no need for quick reactions. I've just pinged @wagner-certat because of the old problem description. :)