intelmq-manager icon indicating copy to clipboard operation
intelmq-manager copied to clipboard

create a version check on initial loading

Open aaronkaplan opened this issue 6 years ago • 6 comments

When the manager is loaded (displayed) for the first time, it shall do a version check:

make a connection to https://intelmq.org/version.json and pull in the following json file:

{
	"intelmq-manager":	"1.0",
	"intelmq":	"1.0.1"
}

After fetching the file, the manager shall compare it's own version and intelmq's version against the given versions in the file. Please present the own version on the upper right side of the screen in small letters like:

intelmq: installed ver. 0.9, latest: 1.0.1
manager: installed ver. 0.6, latest: 1.0

And add a link to the corresponding github repos where the newest version may be downloaded.

Thanks!

aaronkaplan avatar Aug 25 '17 11:08 aaronkaplan

How do you define for the first time? Should this state be saved in the browser as cookie or some other in-browser storage?

The latest intelmq-manager release is 0.2.2. How will this file at intelmq.org be updated?

Please be aware that not all users may want to have version update reminders, especially if updates are handled with some kind of package management.

ghost avatar Aug 28 '17 08:08 ghost

And also see #122 which shows the used version on the about page.

ghost avatar Aug 28 '17 08:08 ghost

To be open for definition. For example: set a cookie which expires in 1 day. Hence , we would have a daily version check. also ok.

Concerning the users who might not want to have that - okay, fair enough. But then they should have some global setting to disable that. By default it should be enabled.

Yes, I am aware of #122.

aaronkaplan avatar Aug 28 '17 08:08 aaronkaplan

Concerning the update of the versions on intelmq.org: https://api.github.com/repos/certtools/intelmq/releases has a JSON-formatted file with all releases including the release notes == changelog. We can regularly get the latest version of this file and

  • serve the latest version number, probably with release date, or
  • list all available versions -> allows the user to see all intermediate versions, release dates and probably the changelog

Showing the changelog could be very effective to show the users what has been fixed/added without going to the changelog themselves

ghost avatar Aug 28 '17 09:08 ghost

please just implement as specified. Thx.

aaronkaplan avatar Aug 28 '17 10:08 aaronkaplan

I already mentionend some of the following statements in yesterdays dev call, now for transparency in public.

I have no good feeling about the "latest version" feature, apart of the privacy concerns. I don't want to discuss the "calling-home" feature now, because I suppose we all know about its implications.

But what I want to mention is:

  • I thought we'd do a "packaging first" approach, meaning all users installing IntelMQ and the IntelMQ-Manager with apt, yum or other tools, would get notified by their packaging system if new versions are available. Why should I notify the user in the web-GUI in such a case?

  • Not every user of the web-GUI is also allowed to update software on the server, as she/he has no admin-rights. How shall she/he react when seeing the outdated version? What should be achieved?

  • Not updating to the latest version is intentional in many cases when complex configuration is required.

  • I doubt that now is the right time to spend resources on such a feature. IMHO there are more important things.

@aaronkaplan: can you please specify in public why this feature is needed?

Idea: What about a "check if your version is the most recent" - link to a webpage showing the most recent version-numbers. This approach can be split into multiple stages:

  1. Stage: Just a website showing the Versionnumbers
  2. Stage: When the link is clicked, the installed version-numbers are transferred to the Website. The Website just shows both numbers and a "check"-mark or a "cross"-mark.
  3. Stage: The Changelog is displayed for the Diff in versions.

dmth avatar Aug 30 '17 07:08 dmth