fame icon indicating copy to clipboard operation
fame copied to clipboard

Change the installation steps, rework fame Dockerfile

Open Augustin-FL opened this issue 4 years ago • 6 comments

This pull requests does ~~3~~ 2 things :

  • Use environment variables for the setup steps for instead of input(). This way, the deployment can be easily automated
  • ~~Unlock dependencies in requirements.txt : Flask is now in 2.0.x, some dependencies are now obsolete~~
  • Rework the Dockerfile and improve the setup of a fame instance using docker.

Augustin-FL avatar Feb 28 '22 12:02 Augustin-FL

@gaelmuller can we merge this? would you like to make a review?

certsocietegenerale avatar Mar 01 '22 08:03 certsocietegenerale

Hi @gaelmuller,

Sorry for the delay. would it be possible to request a second review?

Augustin-FL avatar Mar 22 '22 08:03 Augustin-FL

Thanks for your second review (and sorry for the stupid mistake I made... estimated_document_count, etc)

I'm assuming this time it should be good for merge?

Augustin-FL avatar Mar 30 '22 08:03 Augustin-FL

How did you test this ? 🤔

This is not working on my end (because FAME cannot connect to the database)

Like this :

git clone https://github.com/Augustin-FL/fame
cd fame/docker
git checkout use_env

sed -i 's+git clone https://github.com/certsocietegenerale/fame+git clone https://github.com/Augustin-FL/fame \&\& cd fame \&\& git checkout use_env \&\& cd ..+g' Dockerfile 

cp fame.env.template fame.env
docker-compose build
docker-compose up

Alternatively, you could indeed use COPY instead of RUN git clone, like you did.

What do you mean "FAME cannot connect to the database" ? It does work well on my side ?

docker-compose

Augustin-FL avatar Apr 04 '22 08:04 Augustin-FL

What do you mean "FAME cannot connect to the database" ? It does work well on my side ?

Hi again,

I understand what do you mean now. the issue is the following : mongodb unexpectedly quit after performing init process. I didn't experience the issue because I often CTRL+C when doing my builds, and I don't always reset my volumes.

Let me fix this

Augustin-FL avatar Apr 05 '22 07:04 Augustin-FL

I think you can make a (hopefully final?) review now

Augustin-FL avatar Apr 13 '22 14:04 Augustin-FL