debug-log-analyzer icon indicating copy to clipboard operation
debug-log-analyzer copied to clipboard

chore: update @salesforce/core to latest

Open lcottercertinia opened this issue 2 years ago • 1 comments

Is your feature request related to a problem?

Update @salesforce/core to latest. This version of @salesforce/core removes the bunyan dependency which means we can remove the patched version in this repo. https://github.com/certinia/debug-log-analyzer/tree/main/patches https://github.com/forcedotcom/sfdx-core

There is a version available which handles some of the bundling steps https://www.npmjs.com/package/@salesforce/core-bundle

Edit: seems like we can also remove sfdx auth help. [Org.create) in sfdx core defaults to the default org in current repo.

We can then just throw if no org returned.

try { return await Org.create({ aliasOrUsername: orgName }); } catch (e) { if (!orgNamee) { Throw new error("no default set"); } else { throw e; } }

Check out the deploy start or org open commands for example usage.

If that does not work due to where the code in vscode is executed from we can just replicate the logic in sfdx auth helper to keep the deps down.

https://github.com/forcedotcom/sfdx-core/blob/main/src/org/org.ts

https://github.com/salesforcecli/sf-plugins-core/blob/401832321da60f36d3f98658a6fdf56a5e0d4311/src/flags/orgFlags.ts#L142

https://github.com/salesforcecli/plugin-deploy-retrieve/blob/main/src/commands/project/deploy/start.ts

lcottercertinia avatar Aug 03 '23 08:08 lcottercertinia

Some resources that may help

https://github.com/vitejs/vite/issues/788

https://github.com/nonara/ts-patch/issues/106

https://github.com/nonara/ts-patch?tab=readme-ov-file#usage

There are also apex-node-bundle and core-bundle and we may need to copy sfdx-auth-helper logic.

Another option is to handle the messages in the 2 sf pages so they do not need to be inline.

lcottercertinia avatar Jan 03 '25 23:01 lcottercertinia