Ondřej Čertík

Results 1482 comments of Ondřej Čertík

@assem2002 let's finish this?

You can keep the old pass and run it for other backends, but add a new pass or whatever new way just for the LLVM backend. That way things wouldn't...

@assem2002 let me know when this is ready for review from me.

Ok, so there is one fundamental problem here that we need to fix. Consider, let's say, this test: https://github.com/assem2002/lfortran/edit/descriptor_string_FEEDBACK/tests/reference/asr-string_04-2ebc0e6.stdout?pr=%2Flfortran%2Flfortran%2Fpull%2F4918 In here, we have the `str` variable, declared like this: ```...

Clean ASR and clean backend. When converting descriptor to pointer, you just grab the pointer, but you do it in the visit_cast in the backend (when casting from pointer to...

Yes, exactly. > AST To ASR should be sufficient to catch the needed places where I should cast, right? Yes.

Let's document in the String type in doc/... when each physical type is used. Currently: * if it is allocatalbe, it is DescriptorString * otherwise it is PointerString

This is ready for review. This PR does one change: for allocatable strings it uses DescriptorString physical type now. @gxyd, @Pranavchiku can you please carefully review this PR? At high...

Thanks @gxyd. @Pranavchiku go ahead and review this one as well please.