website icon indicating copy to clipboard operation
website copied to clipboard

Add test step to deploy script

Open vbrown608 opened this issue 9 years ago • 5 comments

see README for test step. it would be nice to encapsulate the test step in a script (like a bash script, rake task, or npm test) so it can be dry-ly referenced in multiple places (ex .travis.yml, readme, deploy script).

vbrown608 avatar May 17 '16 23:05 vbrown608

PR allows tests to run with npm test - described in updated readme.

vbrown608 avatar May 19 '16 00:05 vbrown608

after a lot of battling trying to get htmlproofer installed, npm test now segfaults in some deep ruby call. I'd suggest we add a gemfile or some other form of ruby dependency management to facilitate this, otherwise it's not going to be easy for people to run these tests

SwartzCr avatar May 24 '16 07:05 SwartzCr

while trying to get a pastebin of my segfault it seems to have worked - but - it takes literally forever to run tests (~5 minutes) is that the same in your environment?

SwartzCr avatar May 24 '16 07:05 SwartzCr

HTML proofer only takes me about a minute. It checks external links for 404s, so a slow internet connection probably slows it down quite a bit.

We could disable checking external links if speed is more important.

As I understand it, a gemfile will only lock down the versions of jekyll and html-proofer, and it will introduce a new dependency (bundler). Eventually I think a docker container would be the best solution. In the meantime, we could could specify an html-proofer version in the readme. However, html-proofer doesn't interact directly with any of our code (just built html pages), so any non-broken version should work.

vbrown608 avatar May 24 '16 17:05 vbrown608

I now have a completely broken set-up where psych won't install in ruby and I can no longer run tests or build the website - probably thanks to some cross dependency that htmlproofer pulled in. I've edited the deploy script but I don't want to contribute my changes until I can do an errorless deploy which isn't possible since it will no longer build the docs correctly and thus errors out

SwartzCr avatar May 24 '16 17:05 SwartzCr