certbot icon indicating copy to clipboard operation
certbot copied to clipboard

Dnspod Dns Authenticator

Open liaohuqiu opened this issue 7 years ago • 3 comments

Implement an Authenticator which can fulfill a dns-01 challenge using the Dnspod API. Applicable only for domains using Dnspod for DNS.

Dnspod is a free DNS provider in China. Many of Chinese websites are hosted by them. It is the earliest one that provide free DNS to webmasters in China.

  • Testing Done:

    • tox -e py27
    • tox -e lint
  • Manual testing:

    • Used certbot certonly --dns-dnspod -d, specifying a credentials file as a command line argument. Verified that a certificate was successfully obtained without user interaction.
    • Used certbot certonly --dns-dnspod -d, without specifying a credentials file as a command line argument. Verified that the user was prompted and that a certificate was successfully obtained.
    • Used certbot certonly -d. Verified that the user was prompted for a credentials file after selecting dnspod interactively and that a certificate was successfully obtained.
    • Used certbot renew --force-renewal. Verified that certificates were renewed without user interaction.
  • Negative testing:

    • Path to non-existent credentials file.
    • Credentials file with unsafe permissions (644).
    • Credentials file missing id.
    • Credentials file with blank id.
    • Credentials file with incorrect id.
    • Credentials file missing token.
    • Credentials file with blank token.
    • Credentials file with incorrect token.
    • Domain name not registered to dnspod account.
  • ./tox.cover.sh

    • certbot_dns_dnspod/dns_dnspod.py 100%
    • certbot_dns_dnspod/dns_dnspod_test.py 100%
    • certbot_dns_dnspod/dns_dnspod_client.py 100%
    • certbot_dns_dnspod/dns_dnspod_client_test.py 100%

liaohuqiu avatar Jul 31 '18 09:07 liaohuqiu

Hi, who can check this?

liaohuqiu avatar Aug 09 '18 03:08 liaohuqiu

I used this patch for dnspod and modified to follow the branch master. It worked all right. See https://github.com/realkcn/certbot/tree/test-dnspod

realkcn avatar Oct 29 '18 19:10 realkcn

@realkcn Thanks for your testing.

liaohuqiu avatar Nov 17 '18 01:11 liaohuqiu

we're no longer accepting new first party plugins so i'm going to close this

thanks for working on this though. if you'd like to offer this a 3rd party plugin and open a PR advertising it here like many others have done, you are welcome to do so

bmw avatar Feb 11 '25 18:02 bmw