certbot
certbot copied to clipboard
Refactor Nginx plugin unit tests to decouple test config files
Possible implementations:
- specify test configurations dynamically
- separate file areas for separate modules
Because having to update things in ten places every time we want to test something new slows down development and makes fixing minor bugs take way too long.
The problem is that we use the same test file for many different test cases. Breaking them out at all will be helpful.
Someone at PyCon was working on this and was planning to continue to do so after the sprints. Just mentioning this to avoid duplicate work.
@igy254, definitely don't delete your changes. I also thought you were working on this for Apache rather than Nginx.
Also, I'd love to be wrong, but in my experience, despite people's best intentions, most people rarely follow up with additional work after a hackathon so I think you're safe to continue working on this if you were doing so.
We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no further activity, this issue will be automatically closed.
This is still a great project for a hackathon!
We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.
This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.
i suspect this is still worth doing, reopening
I was looking at having a stab at this - does anyone have more context?