certbot icon indicating copy to clipboard operation
certbot copied to clipboard

Refactor Nginx plugin unit tests to decouple test config files

Open ohemorange opened this issue 8 years ago • 10 comments

Possible implementations:

  • specify test configurations dynamically
  • separate file areas for separate modules

Because having to update things in ten places every time we want to test something new slows down development and makes fixing minor bugs take way too long.

ohemorange avatar Dec 08 '16 00:12 ohemorange

The problem is that we use the same test file for many different test cases. Breaking them out at all will be helpful.

ohemorange avatar Mar 14 '17 00:03 ohemorange

Someone at PyCon was working on this and was planning to continue to do so after the sprints. Just mentioning this to avoid duplicate work.

bmw avatar May 25 '18 16:05 bmw

@igy254, definitely don't delete your changes. I also thought you were working on this for Apache rather than Nginx.

Also, I'd love to be wrong, but in my experience, despite people's best intentions, most people rarely follow up with additional work after a hackathon so I think you're safe to continue working on this if you were doing so.

bmw avatar May 29 '18 20:05 bmw

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no further activity, this issue will be automatically closed.

stale[bot] avatar Jun 09 '19 01:06 stale[bot]

This is still a great project for a hackathon!

ohemorange avatar Jun 12 '19 00:06 ohemorange

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

github-actions[bot] avatar Jun 14 '23 01:06 github-actions[bot]

This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.

github-actions[bot] avatar Jul 14 '23 02:07 github-actions[bot]

i suspect this is still worth doing, reopening

wgreenberg avatar Jul 14 '23 19:07 wgreenberg

I was looking at having a stab at this - does anyone have more context?

tmills80 avatar Oct 05 '23 23:10 tmills80