website icon indicating copy to clipboard operation
website copied to clipboard

Update route53.md

Open atif1996 opened this issue 4 years ago • 6 comments

The route53:ListHostedZones action is also required for acme to renew the certs

atif1996 avatar Jan 01 '22 19:01 atif1996

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jan 01 '22 19:01 jetstack-bot

Hi @atif1996. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 01 '22 19:01 jetstack-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atif1996 To complete the pull request process, please assign jakexks after the PR has been reviewed. You can assign the PR to them by writing /assign @jakexks in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Jan 01 '22 19:01 jetstack-bot

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: ff161b3f1e139d3e818172435e612021f9f4b24c

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61d0aeea3700db0007aa0128

😎 Browse the preview: https://deploy-preview-790--cert-manager-website.netlify.app

netlify[bot] avatar Jan 01 '22 19:01 netlify[bot]

@atif1996: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Apr 13 '22 11:04 jetstack-bot

@atif1996 can you please sign your commits? (see https://cert-manager.io/docs/contributing/sign-off/)

inteon avatar Sep 05 '23 08:09 inteon