website icon indicating copy to clipboard operation
website copied to clipboard

approver-policy doc: fix indentation

Open rptaylor opened this issue 8 months ago • 1 comments

matchNames and matchLabels should be at the same indentation.

$ kubectl explain CertificateRequestPolicy.spec.selector.namespace
GROUP:      policy.cert-manager.io
KIND:       CertificateRequestPolicy
VERSION:    v1alpha1

FIELD: namespace <Object>

DESCRIPTION:
    Namespace is used to match by namespace, meaning the
    CertificateRequestPolicy will only match CertificateRequests
    created in matching namespaces.
    If this field is omitted, resources in all namespaces are checked.
    
FIELDS:
  matchLabels	<map[string]string>
    MatchLabels is the set of Namespace labels that select on
    CertificateRequests which have been created in a namespace matching the
    selector.

  matchNames	<[]string>
    MatchNames is the set of namespace names that select on
    CertificateRequests that have been created in a matching namespace.
    Accepts wildcards "*".

rptaylor avatar Mar 19 '25 19:03 rptaylor

/retest

erikgb avatar Apr 10 '25 08:04 erikgb

Thanks for this! Looks like a clear bugfix.

I am going to close and reopen the PR now to see if it can fix CI.

erikgb avatar Apr 10 '25 09:04 erikgb

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
Latest commit 217de638cb465a3ab898ab2ed99c860da64d2e6f
Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/67f79443c76b0e0008076507
Deploy Preview https://deploy-preview-1658--cert-manager.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 10 '25 09:04 netlify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar Apr 10 '25 11:04 cert-manager-prow[bot]