website
website copied to clipboard
fix instance value used by PodMonitor when selecting pods to monitor
I was trying to setup a PodMonitor using exactly what is defined in the documentation but realised that there were a small error in the 'matchExpressions'.
The label app.kubernetes.io/instance is always set to cert-manager.
I checked the last cert-manager.yaml in the last release:
...
apiVersion: apps/v1
kind: Deployment
metadata:
name: cert-manager
namespace: cert-manager
labels:
app: cert-manager
app.kubernetes.io/name: cert-manager
app.kubernetes.io/instance: cert-manager
app.kubernetes.io/component: "controller"
app.kubernetes.io/version: "v1.17.1"
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: cert-manager
app.kubernetes.io/instance: cert-manager
app.kubernetes.io/component: "controller"
template:
metadata:
labels:
app: cert-manager
app.kubernetes.io/name: cert-manager
app.kubernetes.io/instance: cert-manager
app.kubernetes.io/component: "controller"
app.kubernetes.io/version: "v1.17.1"
...
Otherwise, the documentation is really well done and complete, thanks!
Deploy Preview for cert-manager ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 3f566c8ceaac77af0f297f7c90974e5a63499c0c |
| Latest deploy log | https://app.netlify.com/sites/cert-manager/deploys/67befca6c9ce5a000850e412 |
| Deploy Preview | https://deploy-preview-1652--cert-manager.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for cert-manager ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | d32bca15f3ca5df5f84207e16525e715b96ab939 |
| Latest deploy log | https://app.netlify.com/sites/cert-manager/deploys/67befd0dbd3da00008a62933 |
| Deploy Preview | https://deploy-preview-1652--cert-manager.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [erikgb]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Going to close + reopen this to try and kick CI off!
Maybe its stuck on some old PRs, I can see a couple of PRs in an lgtm approved state that prow has not merged because the verify action for some reason never triggered.
https://github.com/cert-manager/website/pull/1516 https://github.com/cert-manager/website/pull/1583 https://github.com/cert-manager/website/pull/1635
I have closed/reopened those PRs to force the action to run
Closing/Reopening those other tickets fixed the github action which passed and now prow has merged them. Gonna close/reopen this one to see if prow is no longer blocked
That did it 🎉