website icon indicating copy to clipboard operation
website copied to clipboard

v1.9 to v1.10 upgrade instructions does not mention container name change

Open hawksight opened this issue 2 years ago • 4 comments

The documentation for 1.10 release notes does mention this here

But if you just look at the relevant upgrade instructions, this change is not specifically called out, This could for example lead to a situation where a user has two containers in the pods where it crashloops as the newer containers cannot come up due to port conflicts:

$ k get pods -n cert-manager                                                                                                                                                                                    

NAME                                       READY   STATUS             RESTARTS        AGE
cert-manager-559f7bbfcd-9zrqg              1/2     CrashLoopBackOff   108 (32s ago)   8h
cert-manager-cainjector-6d46445566-65gh5   2/2     Running            0               8h
cert-manager-webhook-564c94659d-7fsmx      1/2     CrashLoopBackOff   108 (39s ago)   8h

We call out the OpenShift issue, so I think we should also call out this issue as it should be common enough due to helm's popularity.

hawksight avatar Jul 19 '23 10:07 hawksight

/assign

I'll try to address this

hawksight avatar Jul 19 '23 10:07 hawksight

@hawksight have you had time to work on this?

inteon avatar Feb 12 '24 13:02 inteon

Not yet, but thanks for the reminder. Might not get to it this week.

hawksight avatar Feb 13 '24 07:02 hawksight

I've set this as backlog priority since this is for quite old versions of cert-manager now, but it might still be nice to document. Alternatively, if we wanted to just close this that'd be fine too. Your call @hawksight !

SgtCoDFish avatar Jul 16 '24 08:07 SgtCoDFish