webhook-example icon indicating copy to clipboard operation
webhook-example copied to clipboard

Improve test case

Open cmoulliard opened this issue 5 years ago • 6 comments

  • Ignore idea and _out directory
  • Add missing dot end of the DNS name
  • Update dependencies. To be controlled
  • Uncomment email and ApiSecretRef
  • Add script to fetch kubebuilder binaries
  • Add DNS server. Set additional vars

cmoulliard avatar May 29 '19 08:05 cmoulliard

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cmoulliard To fully approve this pull request, please assign additional approvers. We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar May 29 '19 08:05 jetstack-bot

/assign @munnerz

cmoulliard avatar May 29 '19 09:05 cmoulliard

FYI. The link to the CONTRIBUTING guide is missing @munnerz -> https://github.com/jetstack/cert-manager-webhook-example/blob/master/CONTRIBUTING.md

cmoulliard avatar Jun 03 '19 08:06 cmoulliard

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 7621c67 Remove non used vars. Add setUseAuthoritative(false) to avoid the error : suite.go:49: error waiting for DNS record propagation: Could not determine authoritative nameservers for cert-manager-dns01-tests.example.com.
  • 7415d9a Added local DNS server. Signed-off-by: Charles Moulliard [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jun 03 '19 08:06 jetstack-bot

@munnerz Can you have a look to this ticket ?

cmoulliard avatar Jun 19 '19 14:06 cmoulliard

@cmoulliard: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Mar 09 '20 18:03 jetstack-bot