trust-manager
trust-manager copied to clipboard
cert-manager
nit: Rename "Bundle" to "ClusterBundle"
Since Bundle is cluster-scoped, ClusterBundle seems like it would be the proper name (which seems correct, given that spec.target.namespaceSelector suggests that the Bundle should be at a Cluster scope or need an "AcceptBundle" object in each namespace to indicate that the namespace wants to receive the certs).
Agree with ClusterBundle being a better match for current behaviour, although IIRC from past conversations amongst the maintainer team I've made the case for us to change Bundle to default to only write the target in a single namespace, with the option to write to all.
In any case, I think the behaviour of writing to all namespaces shouldn't be the default and I feel like Bundle would fit pretty well in that case. What do you think?
(Thank you for your contribution!)
EDIT: See #39 which I actually raised about changing the behaviour!
I think ClusterBundle is still a better name since it does not belong to a single namespace. Furthermore this would allow adding a Bundle CRD which is bound to a namespace later. Much like ClusterIssure and Issuer. (See also https://github.com/cert-manager/trust-manager/issues/131#issuecomment-1656545012)
@erikgb: You must be a member of the cert-manager/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.
In response to this:
/milestone trust-manager v1
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
(Added to milestone, annoying that there's another group for it!)
FWIW I agree about Bundle / ClusterBundle now. I see the use case and I think it's worth renaming the resource we currently have to ClusterBundle. I also see the value in adding Bundle as a namespace-scoped resource, but I'm currently inclined to think we don't need to do both things at once.
I suspect we'll make the rename from Bundle -> ClusterBundle in v1alpha2 or v1beta1, which is on the roadmap after us hearing so much demand for trust-manager v1 at KubeCon NA in Chicago!