trust-manager icon indicating copy to clipboard operation
trust-manager copied to clipboard

#14 Updating the apiVersion to v2

Open joscabmar opened this issue 2 years ago • 2 comments

This should solve #14

Signed-off-by: Jose Antonio [email protected]

joscabmar avatar Oct 17 '22 15:10 joscabmar

Hi @joscabmar. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Oct 17 '22 15:10 jetstack-bot

/ok-to-test

inteon avatar Oct 28 '22 08:10 inteon

/approve

JoshVanL avatar Nov 01 '22 16:11 JoshVanL

@joscabmar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-trust-verify 4c34b21fe4e00d8cd2083cdc8940fca02cbc6444 link true /test pull-cert-manager-trust-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Nov 02 '22 08:11 jetstack-bot

/retest

JoshVanL avatar Nov 03 '22 10:11 JoshVanL

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, joscabmar, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Nov 03 '22 10:11 jetstack-bot

/lgtm

JoshVanL avatar Nov 03 '22 10:11 JoshVanL

This test no longer exists.

/override pull-cert-manager-trust-verify

JoshVanL avatar Nov 03 '22 11:11 JoshVanL

@JoshVanL: Overrode contexts on behalf of JoshVanL: pull-cert-manager-trust-verify

In response to this:

This test no longer exists.

/override pull-cert-manager-trust-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Nov 03 '22 11:11 jetstack-bot