Add issuer kind and group to issuerRef. This is a self signed certificate for webhook and as such setting the values directly

[sitaramkm]

Update Certificate resource to include kind and group in the issuerRef. Allows for more granular policy control when used in combination with approver-policy (CertificateRequestPolicy) Fixes #55

Signed-off-by: Sitaram IYER [email protected]

[jetstack-bot]

Hi @sitaramkm. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sitaramkm]

/assign @JoshVanL

[JoshVanL]

Thanks @sitaramkm, please increase the Chart patch version, re-generate the helm docs with make update-helm-docs so we can cut a chart release.

[sitaramkm]

Thanks @sitaramkm, please increase the Chart patch version, re-generate the helm docs with make update-helm-docs so we can cut a chart release.

Done @JoshVanL

[JoshVanL]

/lgtm /approve /ok-to-test

[JoshVanL]

Unrelated failure- we need to increase the timeout for our tests.

/retest

[JoshVanL]

Again, looks like our timeout are no longer permissive enough.

[JoshVanL]

/retest

[jetstack-bot]

@sitaramkm: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

New changes are detected. LGTM label has been removed.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoshVanL, sitaramkm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment