trust-manager
trust-manager copied to clipboard
cert-manager
WIP: refactor: dedicated struct for building source data
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![cert-manager-prow[bot] avatar](https://avatars.githubusercontent.com/in/877404?v=4 "Published by a pub.dev verified publisher"){kind=small}
@SgtCoDFish Would it be possible for you to review this PR? It's been open for "a while", and I am a bit tired of rebasing it. 😅 So I would like to know if this refactoring might be acceptable.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Closing in favor of https://github.com/cert-manager/trust-manager/pull/648
/close
@erikgb: Closed this PR.
In response to this:
Closing in favor of https://github.com/cert-manager/trust-manager/pull/648
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.