trust-manager icon indicating copy to clipboard operation
trust-manager copied to clipboard

refactor: more generic target handling

Open erikgb opened this issue 1 year ago • 2 comments

In this PR I am trying to make the code for handling targets (configmaps and secrets) even more generic. My initial goal was to fully remove the code duplication for configmaps/secrets, but I do see (at least not now) how that can be done. I am suggesting merging this as a step forward for now.

erikgb avatar Sep 19 '24 18:09 erikgb

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

cert-manager-prow[bot] avatar Sep 19 '24 18:09 cert-manager-prow[bot]

As you said, this PR does not reduce/ deduplicate code yet. I'm ok with merging this if you think this will bring us closer to a refactor where it will be possible to deduplicate the code. /lgtm /approve

inteon avatar Nov 21 '24 12:11 inteon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar Nov 21 '24 12:11 cert-manager-prow[bot]

@inteon The PR is rebased now. Need a new LGTM.

erikgb avatar Nov 21 '24 12:11 erikgb

/lgtm

inteon avatar Nov 21 '24 13:11 inteon