trust-manager
trust-manager copied to clipboard
refactor: more generic target handling
In this PR I am trying to make the code for handling targets (configmaps and secrets) even more generic. My initial goal was to fully remove the code duplication for configmaps/secrets, but I do see (at least not now) how that can be done. I am suggesting merging this as a step forward for now.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
As you said, this PR does not reduce/ deduplicate code yet. I'm ok with merging this if you think this will bring us closer to a refactor where it will be possible to deduplicate the code. /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: inteon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [inteon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@inteon The PR is rebased now. Need a new LGTM.
/lgtm