trust-manager
trust-manager copied to clipboard
cert-manager
Add a design for public trust bundles
This proposal introduces a design by which bundles are stored in sidecar containers and consumed from a shared path by the controller container.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SgtCoDFish
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [SgtCoDFish]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test pull-cert-manager-trust-verify
I've updated the guide with proposed workflows for both static and dynamic bundles :+1:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SgtCoDFish
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [SgtCoDFish]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Pushed an updated version of the design which more closely matches the version as implemented currently in #46
Attempts to laser-focus on the problem which I'd expect most users to want to solve, which is to add a single public trust 'package' and to easily refer to it in Bundle resources.
/override pull-trust-manager-verify
Obviously flaking given none of the tests are changed in this PR!
@SgtCoDFish: Overrode contexts on behalf of SgtCoDFish: pull-trust-manager-verify
In response to this:
/override pull-trust-manager-verify
Obviously flaking given none of the tests are changed in this PR!
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@SgtCoDFish: Overrode contexts on behalf of SgtCoDFish: pull-trust-manager-verify
In response to this:
/override pull-trust-manager-verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I didn't realise this was still open!
We've now merged the actual feature, so there's no real reason to have this remain open. As such, I'll manually add an LGTM label so this merges.
/override pull-trust-manager-verify /override pull-trust-manager-smoke
(obviously not ideal that these failed, but also obviously not related to this PR)
@SgtCoDFish: Overrode contexts on behalf of SgtCoDFish: pull-trust-manager-smoke, pull-trust-manager-verify
In response to this:
/override pull-trust-manager-verify /override pull-trust-manager-smoke
(obviously not ideal that these failed, but also obviously not related to this PR)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.