trust-manager icon indicating copy to clipboard operation
trust-manager copied to clipboard

Evaluate trust namespace value as template

Open heruan opened this issue 1 year ago • 1 comments

When installing trust-manager as a subchart (i.e. dependency) it would be useful to automatically set the trust namespace value to the release namespace, or another dynamic value. At the moment this is unfortunately not possibile since the app.trust.namespace value is evaluated as-is and so it needs to be always explicitly specified if you don't want the default one.

This can be easily solved if the value were evaluated as a template, e.g.

 metadata:
   name: {{ include "trust-manager.name" . }}
-  namespace: {{ .Values.app.trust.namespace }}
+  namespace: {{ tpl .Values.app.trust.namespace . }}

Then it would be possibile to set the trust namespace dynamically, e.g.

# Subchart configuration when trust-manager is a dependency
trust-manager:
  app:
    trust:
      namespace: {{ .Release.Namespace }}

Is this something that might be worth a PR? I'd be happy to contribute!

heruan avatar Feb 15 '24 07:02 heruan

Alternatively, we might add a special value/ additional option to make it match the release namespace. I think that there are probably only a limited set of values that we would like to create templates for, so maybe templating is overkill and might introduce unexpected problems/ security issues.

inteon avatar Aug 29 '24 10:08 inteon

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. /lifecycle stale

cert-manager-bot avatar Nov 27 '24 11:11 cert-manager-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. /lifecycle rotten /remove-lifecycle stale

cert-manager-bot avatar Dec 27 '24 11:12 cert-manager-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

cert-manager-bot avatar Jan 26 '25 11:01 cert-manager-bot

@cert-manager-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cert-manager-prow[bot] avatar Jan 26 '25 11:01 cert-manager-prow[bot]