trust-manager icon indicating copy to clipboard operation
trust-manager copied to clipboard

Way to add labels/annotations to target

Open james-callahan opened this issue 3 years ago • 6 comments

I would like to be able to add labels and annotations to the target.

james-callahan avatar May 02 '22 04:05 james-callahan

I would also like to do that.

My use case is in combination with https://github.com/stakater/Reloader. I would like to set the reloader.stakater.com/match annotation.

59977 avatar May 13 '22 12:05 59977

If ever implemented, I think we should get inspiration from the secretTemplate in cert-manager Certificate.

erikgb avatar Jul 28 '23 19:07 erikgb

/good-first-issue

erikgb avatar Aug 28 '23 15:08 erikgb

@erikgb: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Aug 28 '23 15:08 jetstack-bot

As a work around you can pre-create the configmap like this:

apiVersion: v1
kind: ConfigMap
metadata:
  name: {{ .Values.bundle.name }}
  annotations:
    reloader.stakater.com/match: "true"

Trust manager will then use this existing configmap to add the bundle to and the annotation is set.

knaruf avatar Sep 02 '23 09:09 knaruf