istio-csr
istio-csr copied to clipboard
cert-manager
Add `PodDisruptionBudget` to helm chart
Hi @frauniki. Thanks for your PR.
I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![cert-manager-prow[bot] avatar](https://avatars.githubusercontent.com/in/877404?v=4 "Published by a pub.dev verified publisher"){kind=small}
@erikgb @wallrj @SgtCoDFish Hello, could you please review this pull request? Or, if you know who would be appropriate to ask for a review, could you let me know?
@hawksight I fixed the error that was occurring in CI. Could you please run the test CI again?
/lgtm
I think in the current state it's safe to merge. People have to opt into this, at which point they should make their own choice about what setting is best for their installation.
Thank you @ajvn for the lengthy input on this topic too for getting a good default.
At this point we diverge from cert-manager docs, but I think we can revisit that if important later on.
@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
/lgtm
I think in the current state it's safe to merge. People have to opt into this, at which point they should make their own choice about what setting is best for their installation.
Thank you @ajvn for the lengthy input on this topic too for getting a good default.
At this point we diverge from cert-manager docs, but I think we can revisit that if important later on.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I will review this later today or tomorrow. The generated Helm docs can be improved, I think, but I need to find out exactly how. Maybe @frauniki can take a look at https://github.com/cert-manager/helm-tool?
@erikgb: The label(s) /label tide/merge-method-squash cannot be applied. These labels are supported: ``. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
Thanks a lot, @frauniki. Especially for the last-minute adjustments. 🚀
/label tide/merge-method-squash /lgtm /approve
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: erikgb, hawksight
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [erikgb]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@erikgb: The label(s) /label tide/squash cannot be applied. These labels are supported: ``. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label tide/squash
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.