Add support for impersonation for certificate requests

[paulwilljones]

Resolves #331

[cert-manager-prow[bot]]

Hi @paulwilljones. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[SgtCoDFish]

/ok-to-test

[inteon]

@paulwilljones the automated tests found some issues: https://storage.googleapis.com/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_istio-csr/336/pull-cert-manager-istio-csr-verify/1813889849741021184/build-log.txt

[paulwilljones]

/retest

[paulwilljones]

@inteon @SgtCoDFish I added an e2e test for Ambient. Can we add this to Prow for Istio 1.22 onwards?

[inteon]

@inteon @SgtCoDFish I added an e2e test for Ambient. Can we add this to Prow for Istio 1.22 onwards?

The tests are defined here: https://github.com/cert-manager/testing/blob/master/config/jobs/cert-manager/istio-csr/cert-manager-istio-csr-presubmits.yaml We probably should start by adding this as an optional test so other PRs are not blocked.

[paulwilljones]

@inteon @SgtCoDFish I added an e2e test for Ambient. Can we add this to Prow for Istio 1.22 onwards?

The tests are defined here: https://github.com/cert-manager/testing/blob/master/config/jobs/cert-manager/istio-csr/cert-manager-istio-csr-presubmits.yaml We probably should start by adding this as an optional test so other PRs are not blocked.

Added https://github.com/cert-manager/testing/pull/1050 to run Ambient e2e tests for 1.22

[SgtCoDFish]

It looks like #357 caused quite a few conflicts with this PR - sorry about that!

[inteon]

I'll upgrade the istio package in https://github.com/cert-manager/istio-csr/pull/385, this should reduce the diff for this PR a bit.

[cert-manager-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment