istio-csr icon indicating copy to clipboard operation
istio-csr copied to clipboard

Image version is v0.0.0

Open anfechtung opened this issue 1 year ago • 4 comments

A recent change set the Chart.yaml image version value to v0.0.0 which does not align with an actual oci image tag:

appVersion: v0.0.0
version: v0.0.0

https://github.com/cert-manager/istio-csr/blob/main/deploy/charts/istio-csr/Chart.yaml#L26

This is causing our deployments to fail.

anfechtung avatar Mar 11 '24 15:03 anfechtung

We do not support installing the Helm chart directly from GitHub (unless for development), instead the https://charts.jetstack.io chart repo should be used. See https://cert-manager.io/docs/usage/istio-csr/installation/ for the full installation instructions.

inteon avatar Mar 12 '24 08:03 inteon

So the change to v0.0.0 was deliberate to essentially prevent deployment from the GitRepo? Unfortunately, the process I am using to deploy istio-csr requires me to use a Flux GitRepository as the source.

anfechtung avatar Mar 14 '24 17:03 anfechtung

We changed the value because the version in the git repo will not match the latest version in the future. We overwrite the value before we create the Helm chart and publish it, this simplifies the release process (does no longer require us to manually update these files). The best solution would be to use Flux HelmRepository instead of Flux GitRepository.

inteon avatar Mar 14 '24 17:03 inteon

Understood. Thank you. I will open an issue with product we are using to orchestrate our deployment, asking them to support HelmRepository.

anfechtung avatar Mar 14 '24 17:03 anfechtung