Add ability to pass in extra pod labels/annotations
Addresses this issue https://github.com/cert-manager/istio-csr/issues/211
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @aburan28. Thanks for your PR.
I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
@aburan28 Please run "make generate" to update the README.md that is generated based on the values.yaml file.
Updated with the make generate output
/retest
/retest
Anything else needed for this PR?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@aburan28: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cert-manager-istio-csr-test-ecc | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-test-ecc |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@aburan28: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cert-manager-istio-csr-istio-v1-19 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-19 |
| pull-cert-manager-istio-csr-istio-v1-18 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-18 |
| pull-cert-manager-istio-csr-istio-v1-15 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-15 |
| pull-cert-manager-istio-csr-istio-v1-16 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-16 |
| pull-cert-manager-istio-csr-istio-v1-14 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-14 |
| pull-cert-manager-istio-csr-istio-v1-20 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-20 |
| pull-cert-manager-istio-csr-istio-v1-17 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-17 |
| pull-cert-manager-istio-csr-istio-v1-22 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-22 |
| pull-cert-manager-istio-csr-istio-v1-21 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-21 |
| pull-cert-manager-istio-csr-pure-runtime-config | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-pure-runtime-config |
| pull-cert-manager-istio-csr-istio-v1-23 | 3286d1310f0a58a275ba47779829d04372e2a135 | link | true | /test pull-cert-manager-istio-csr-istio-v1-23 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Closing this in favour of #372 - sorry this took a while to get around to @aburan28 !