csi-driver icon indicating copy to clipboard operation
csi-driver copied to clipboard

Added options to all containers

Open waterfoul opened this issue 3 years ago • 6 comments

Added options to override service account information, volumes, securityContext, and resources for all containers

waterfoul avatar Jan 03 '23 17:01 waterfoul

Hi @waterfoul. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Jan 03 '23 17:01 jetstack-bot

/assign @wallrj

waterfoul avatar Jan 03 '23 17:01 waterfoul

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: waterfoul To complete the pull request process, please ask for approval from wallrj after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Feb 09 '23 09:02 jetstack-bot

/ok-to-test

inteon avatar Feb 09 '23 09:02 inteon

@waterfoul: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Feb 17 '23 19:02 jetstack-bot

@waterfoul: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-csi-driver-verify 2ec8a8b161e802a82708d5a998b0917c5e45c601 link true /test pull-cert-manager-csi-driver-verify
pull-cert-manager-csi-driver-test 2ec8a8b161e802a82708d5a998b0917c5e45c601 link true /test pull-cert-manager-csi-driver-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Jan 11 '24 13:01 jetstack-bot