csi-driver-spiffe icon indicating copy to clipboard operation
csi-driver-spiffe copied to clipboard

Add option for DNS SAN based on SA name

Open SgtCoDFish opened this issue 1 year ago • 2 comments

Creating this on @jsalowey 's behalf since he's having permission errors. Hopefully this should get us unblocked and able to start discussing the actual PR.

To be clear: this is Joe's work, not mine!

SgtCoDFish avatar Sep 24 '24 14:09 SgtCoDFish

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 85eeda9 Add option for DNS SAN based on SA name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cert-manager-prow[bot] avatar Sep 24 '24 14:09 cert-manager-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sgtcodfish. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar Sep 24 '24 14:09 cert-manager-prow[bot]

I don't think this is going to be worked on, closing.

SgtCoDFish avatar Jun 17 '25 14:06 SgtCoDFish