chore: allow additional properties in Helm setup #7668

[philippeckelintive]

Pull Request Motivation

Fixes #7668

Kind

/kind

Release Note

NONE

[cert-manager-prow[bot]]

@philippeckelintive: The label(s) kind/release, kind/note cannot be applied, because the repository doesn't have them.

In response to this:

Pull Request Motivation

Fixes #7668

Kind

/kind

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cert-manager-prow[bot]]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• 92ddc08 chore: allow additional properties in Helm setup #7668

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[cert-manager-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[cert-manager-prow[bot]]

Hi @philippeckelintive. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[erikgb]

I think you should instead disable Helm schema validation in cases where it's needed. Ref. https://github.com/helm/helm/pull/12743. Allowing additional properties somehow defeats the purpose of schema validation (for everyone).

[cert-manager-bot]

Issues go stale after 6 months of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues remain open for an additional 3 months of inactivity and then close. If this issue is safe to close now please do so with /close. /lifecycle stale