cert-manager icon indicating copy to clipboard operation
cert-manager copied to clipboard

ClusterIssuer read caBundle from Secret

Open jastBytes opened this issue 11 months ago • 9 comments

Pull Request Motivation

Implement issue #7520.

Kind

/kind feature

Release Note

ClusterIssuer allows specifying `.caBundleSecretRef` to support using a caBundle from a Secret instead of the inline value in `.caBundle`.

jastBytes avatar Jan 23 '25 13:01 jastBytes

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar Jan 23 '25 13:01 cert-manager-prow[bot]

Hi @jastBytes. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cert-manager-prow[bot] avatar Jan 23 '25 13:01 cert-manager-prow[bot]

Hi there! Anything I could do pushing this?

jastBytes avatar Mar 12 '25 08:03 jastBytes

I would also be interested in this feature

Adi146 avatar Apr 24 '25 15:04 Adi146

as a trust-manager user, this would be chicken-egg problem with remote PKI

mimianddaniel avatar May 09 '25 17:05 mimianddaniel

as a trust-manager user, this would be chicken-egg problem with remote PKI

We are hoping to make trust-manager not require cert-manager, so hopefully chicken-egg will resolve. 😊

erikgb avatar May 09 '25 18:05 erikgb

as a trust-manager user, this would be chicken-egg problem with remote PKI

We are hoping to make trust-manager not require cert-manager, so hopefully chicken-egg will resolve. 😊 Let me know 👍

mimianddaniel avatar May 09 '25 21:05 mimianddaniel

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cert-manager-prow[bot] avatar Jun 09 '25 14:06 cert-manager-prow[bot]