cert-manager icon indicating copy to clipboard operation
cert-manager copied to clipboard

Vault Issuer Read caBundle from ConfigMap

Open erikgb opened this issue 2 years ago • 12 comments

Is your feature request related to a problem? Please describe.

We use company-internal PKI a lot and are starting to adopt https://github.com/cert-manager/trust-manager to distribute trust anchors throughout our clusters. When attempting to configure a Vault issuer against an external Vault, with a certificate issued by our internal root CA, we have to configure the issuer with a custom caBundle - to avoid TLS handshake errors.

The problem is that the Vault issuer doesn't currently allow loading caBundle from configmaps, only secrets - using the caBundleSecretRef field. This seems to have been discussed in the PR that added the new feature for loading CA certificates from secret.

Describe the solution you'd like I would like the ability to configure Vault issuers with a custom caBundle from configmaps. That will allow us to use the configmaps already distributed by trust-manager.

Describe alternatives you've considered

Simple workaround is to create a custom secret for this, and refer to it from the Vault issuer. But that means we have duplicated information in our clusters and more trust roots to maintain.

Additional context

Related issue: https://github.com/cert-manager/cert-manager/issues/5514

/kind feature /area vault /area api

erikgb avatar May 30 '23 14:05 erikgb

+1 we should add a caBundleConfigMapRef field caBundleSecretRef and caBundleConfigMapRef should be added to Vault and Venafi issuers

@erikgb quick tip: you can already "globally" use a custom ca by mounting your configmap in cert-manager's trust store /etc/ssl/certs/.

inteon avatar Jun 15 '23 07:06 inteon

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to jetstack. /lifecycle stale

jetstack-bot avatar Sep 13 '23 08:09 jetstack-bot

@erikgb see https://github.com/cert-manager/cert-manager/pull/6228 for the design document & feel free to leave a review.

inteon avatar Sep 13 '23 08:09 inteon

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Send feedback to jetstack. /lifecycle rotten /remove-lifecycle stale

jetstack-bot avatar Oct 13 '23 08:10 jetstack-bot

/remove-lifecycle stale

erikgb avatar Oct 13 '23 08:10 erikgb

/remove-lifecycle rotten

erikgb avatar Oct 13 '23 08:10 erikgb

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to jetstack. /lifecycle stale

jetstack-bot avatar Jan 11 '24 09:01 jetstack-bot

/remove-lifecycle stale

inteon avatar Jan 11 '24 10:01 inteon

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. /lifecycle stale

jetstack-bot avatar Apr 10 '24 10:04 jetstack-bot

/remove-lifecycle stale

erikgb avatar Apr 10 '24 11:04 erikgb

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. /lifecycle stale

cert-manager-bot avatar Jul 09 '24 11:07 cert-manager-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. /lifecycle rotten /remove-lifecycle stale

cert-manager-bot avatar Aug 08 '24 11:08 cert-manager-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

cert-manager-bot avatar Sep 07 '24 12:09 cert-manager-bot

@cert-manager-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cert-manager-prow[bot] avatar Sep 07 '24 12:09 cert-manager-prow[bot]